Skip to content

r/aws_pinpointsmsvoicev2_phone_number: Support SHORT_CODE import with creation validation #44537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

r/aws_pinpointsmsvoicev2_phone_number: Support SHORT_CODE import with creation validation #44537

wants to merge 2 commits into from
+43 −1

Conversation

naari3
Copy link

@naari3 naari3 commented Oct 3, 2025 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No changes to security controls.

Description

This PR fixes the number_type attribute to support SHORT_CODE number types while preventing their creation via Terraform.

Background:
While SHORT_CODE cannot be created via the RequestPhoneNumber API (hence it's not in RequestableNumberType), short codes CAN be provisioned through AWS Support cases. Once provisioned, these resources exist in AWS and can be described via DescribePhoneNumbers API.

Use Case:

  • Import existing SHORT_CODE resources created via AWS Support
  • Manage attributes (tags, opt-out lists, deletion protection, etc.) of these imported resources
  • Ensure drift detection works correctly

Changes:

  1. Updated number_type schema from RequestableNumberType to NumberType enum to allow SHORT_CODE values during import and read operations
  2. Added validation in Create function to prevent SHORT_CODE creation attempts with a clear, actionable error message directing users to AWS Support
  3. Added acceptance test to verify the validation error

Relations

Closes #41697

Output from Acceptance Testing

% make testacc TESTS=TestAccPinpointSMSVoiceV2PhoneNumber_shortCodeCreateValidation PKG=pinpointsmsvoicev2

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 b-pinpointsmsvoicev2-phone-number-short-code-validation 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/pinpointsmsvoicev2/... -v -count 1 -parallel 20 -run='TestAccPinpointSMSVoiceV2PhoneNumber_shortCodeCreateValidation'  -timeout 360m -vet=off
2025/10/03 18:27:29 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/03 18:27:29 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccPinpointSMSVoiceV2PhoneNumber_shortCodeCreateValidation
=== PAUSE TestAccPinpointSMSVoiceV2PhoneNumber_shortCodeCreateValidation
=== CONT  TestAccPinpointSMSVoiceV2PhoneNumber_shortCodeCreateValidation
--- PASS: TestAccPinpointSMSVoiceV2PhoneNumber_shortCodeCreateValidation (5.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pinpointsmsvoicev2	11.198s

@naari3 naari3 requested a review from a team as a code owner October 3, 2025 09:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025 •
edited
Loading

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/pinpointsmsvoicev2 Issues and PRs that pertain to the pinpointsmsvoicev2 service. size/S Managed by automation to categorize the size of a PR. labels Oct 3, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 3, 2025
@naari3 naari3 mentioned this pull request Oct 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/pinpointsmsvoicev2 Issues and PRs that pertain to the pinpointsmsvoicev2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_pinpointsmsvoicev2_phone_number
2 participants
@naari3 @justinretzolk